Feat: added ssl_supported_protocols option
#131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
karenzone
reviewed
Mar 21, 2022
Contributor
karenzone
left a comment
karenzone
left a comment
There was a problem hiding this comment.
Left some comments for consideration inline.
kaisecheng
reviewed
Mar 21, 2022
kaisecheng
reviewed
Mar 21, 2022
spec/outputs/http_spec.rb
Outdated
| @server = start_app_and_wait(TestApp, &server_setup) | ||
| end | ||
|
|
||
| let(:server_setup) { lambda { |_| } } |
Contributor
There was a problem hiding this comment.
why this lambda is required?
kaisecheng
approved these changes
Mar 21, 2022
Contributor
kaisecheng
left a comment
kaisecheng
left a comment
There was a problem hiding this comment.
The actual change looks good. It takes the new option from mixin http_client. Thanks for the effort refactoring the test 🏅 . I left one question to the test
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actual option implementation provided by mixin logstash-plugins/logstash-mixin-http_client#40